-
Notifications
You must be signed in to change notification settings - Fork 862
Made tcp connection context-aware #2718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## gprusak-mux #2718 +/- ##
===============================================
- Coverage 43.89% 42.88% -1.01%
===============================================
Files 1914 1565 -349
Lines 159379 125227 -34152
===============================================
- Hits 69952 53703 -16249
+ Misses 83000 66639 -16361
+ Partials 6427 4885 -1542
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| import ( | ||
| protoreflect "google.golang.org/protobuf/reflect/protoreflect" | ||
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | ||
| reflect "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import
| protoimpl "google.golang.org/protobuf/runtime/protoimpl" | ||
| reflect "reflect" | ||
| sync "sync" | ||
| unsafe "unsafe" |
Check notice
Code scanning / CodeQL
Sensitive package import
This simplifies usage of the connection (connection errors are not leaked all over the place) at the cost of running a background task for connection management. Additionally: