Skip to content

Conversation

@pompon0
Copy link
Contributor

@pompon0 pompon0 commented Jan 20, 2026

This simplifies usage of the connection (connection errors are not leaked all over the place) at the cost of running a background task for connection management. Additionally:

  • added a NodeSecretKey/NodePublicKey wrappers of ed25519 keys, which can be solely used for connection authentication (domain separation from validator keys)
  • rewritten (deprecated) protoio to handle context-aware connections
  • moved authentication from SecretConnection to Router.handshake, which will eventually also handle handshaking the giga p2p connections.
  • Moved p2p proto messages to use the the upstream proto generator.
  • renamed import from "proto" to (deprecated) "gogoproto" within sei-tendermint/internal to avoid collision with the upstream proto library that will replace gogoproto.

@github-actions
Copy link

github-actions bot commented Jan 20, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 21, 2026, 5:30 PM

@pompon0 pompon0 marked this pull request as ready for review January 20, 2026 15:12
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.88%. Comparing base (723d44e) to head (b7d617a).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           gprusak-mux    #2718      +/-   ##
===============================================
- Coverage        43.89%   42.88%   -1.01%     
===============================================
  Files             1914     1565     -349     
  Lines           159379   125227   -34152     
===============================================
- Hits             69952    53703   -16249     
+ Misses           83000    66639   -16361     
+ Partials          6427     4885    -1542     
Flag Coverage Δ
sei-chain 45.90% <ø> (+<0.01%) ⬆️
sei-cosmos 38.20% <ø> (-0.01%) ⬇️
sei-db 69.43% <ø> (ø)
sei-tendermint ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 357 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

import (
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import

Certain system packages contain functions which may be a possible source of non-determinism
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
reflect "reflect"
sync "sync"
unsafe "unsafe"

Check notice

Code scanning / CodeQL

Sensitive package import

Certain system packages contain functions which may be a possible source of non-determinism
Base automatically changed from gprusak-mux to main January 21, 2026 16:37
@pompon0 pompon0 enabled auto-merge (squash) January 21, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants