Trace gas check failures #2714
Draft
Trace gas check failures #2714
+60
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed transactions This documents the root cause of trace gas check failures for failed transactions in historical blocks. The issue is caused by the 'double refund' bug in the go-ethereum fork that was fixed in PR #2692 (v1.15.7-sei-14). Key findings: - Trace gas > receipt gas for failed transactions in historical blocks - Caused by incorrect refund application for failed transactions before the fix - Receipts stored incorrect (lower) gas values - Trace replay with current code correctly calculates gas (higher) Includes recommended resolution options for validation tools. Co-authored-by: kartik <kartik@seinetwork.io>
|
Cursor Agent can help with this pull request. Just |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2714 +/- ##
==========================================
- Coverage 43.76% 43.75% -0.01%
==========================================
Files 1914 1914
Lines 159512 159512
==========================================
- Hits 69803 69798 -5
- Misses 83287 83291 +4
- Partials 6422 6423 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR adds documentation (
docs/TRACE_GAS_CHECK_DISCREPANCY.md) to explain trace gas check failures for historical failed transactions. The discrepancy (trace gas > receipt gas) is caused by a "double refund" bug in the go-ethereum fork (fixed in PR #2692) that incorrectly applied gas refunds to failed transactions in older blocks. The document clarifies the root cause, impact, and provides recommendations for validation tools.Testing performed to validate your change
The change is purely documentation. The content was validated through an investigation that confirmed the "double refund" bug as the root cause for the observed gas discrepancies in historical blocks.
Slack Thread