Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+364
to
+373
| for kind, cfg := range m.cfg.Kinds { | ||
| remCfg, ok := handshake.Kinds[kind] | ||
| if !ok { | ||
| remCfg = &StreamKindConfig{} | ||
| } | ||
| inner.acceptsSem[kind] = min(cfg.MaxAccepts, remCfg.MaxConnects) | ||
| for range min(cfg.MaxConnects, remCfg.MaxAccepts) { | ||
| m.kinds[kind].connectsQueue <- inner.newConnectStream(kind) | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
codchen
approved these changes
Jan 21, 2026
Collaborator
codchen
left a comment
codchen
left a comment
There was a problem hiding this comment.
logics themselves look good. Have a q about context
|
|
||
| // NewMux constructs a new multipexer. | ||
| // Remember to spawn Mux.Run() afterwards. | ||
| func NewMux(cfg *Config) *Mux { |
Collaborator
There was a problem hiding this comment.
what's the input/output of this multiplexer?
Contributor
Author
There was a problem hiding this comment.
Streams of messages of fixed size. This will be used for p2p communication between nodes in giga (mainly consensus messages and block syncing). It is like a gRPC server/client, but with stricter semantics.
stevenlanders
approved these changes
Jan 21, 2026
yzang2019
added a commit
that referenced
this pull request
Jan 21, 2026
* main: update: set MaxPacketMsgPayloadSize use MB unit (#2729) fix: set max packet msg payload default to 1MB (#2725) Add CI workflow to build libwasmvm dynamic libraries (#2724) Made tcp connection context-aware (#2718) tcp multiplexer for sei giga (#2679) [STO-237] remove unused cosmos invariants (#2719)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCP Multiplexer for sei giga. It is a replacement for sei-tendermint/internal/p2p/conn.MConnection. It will be used with autobahn only (currently unused). The high level overview of the protocol is described in package comment in mux/mux.go