[SEI-9449] Remove unused invariant checks#2275
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2275 +/- ##
==========================================
+ Coverage 60.24% 60.32% +0.07%
==========================================
Files 311 311
Lines 30240 30273 +33
==========================================
+ Hits 18219 18261 +42
+ Misses 10734 10723 -11
- Partials 1287 1289 +2
🚀 New features to boost your workflow:
|
codchen
reviewed
Aug 4, 2025
|
|
||
| optimisticProcessingInfo *OptimisticProcessingInfo | ||
| optimisticProcessingInfo OptimisticProcessingInfo | ||
| optimisticProcessingInfoMutex sync.RWMutex |
Collaborator
There was a problem hiding this comment.
Is this mutex change intended? Do we see race conditions without it?
Contributor
Author
There was a problem hiding this comment.
yes without it there's race conditions in this test: TestSkipOptimisticProcessingOnUpgrade
sei-will
approved these changes
Aug 4, 2025
philipsu522
approved these changes
Aug 4, 2025
codchen
approved these changes
Aug 8, 2025
jewei1997
added a commit
that referenced
this pull request
Aug 11, 2025
* remove invariant checks * fix test * fix race condition in test * fix lint * add coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
pulling in sei-cosmos changes for removing unused invariant checks here sei-protocol/sei-cosmos#593
Testing performed to validate your change
N/A