feat: add option to override placementStrategy for bootstrap command#249
Merged
feat: add option to override placementStrategy for bootstrap command#249
Conversation
petedannemann
previously approved these changes
Jan 7, 2026
Contributor
|
Any reason not to use |
Contributor
Author
Thanks for the suggestion, I've updated the PR accordingly. |
petedannemann
approved these changes
Jan 7, 2026
hhahn-tw
reviewed
Jan 7, 2026
hhahn-tw
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently,
bootstrapcommand only generates topic configs with a placement strategy ofany. A better default value would becross-rackas it aligns with what Kafka does when topics are created using its tooling.In the given case that this placement strategy is not the desired one, I've updated the bootstrap command to add support for
placement-strategy-overwriteflag. It defaults to the proposedcross-rackstrategy if not provided but gives the opportunity to change it to any of the other strategies.Testing
$ topicctl bootstrap topic-static --cluster-config="examples/local-cluster/cluster.yaml"$ topicctl bootstrap topic-static --cluster-config="examples/local-cluster/cluster.yaml" --placement-strategy-overwrite="any"