Rebalance of topics with no config files#245
Merged
Conversation
…h no config files
Contributor
|
Sorry if you were already planning on doing this, but could you perhaps add a |
Contributor
Author
My bad, didn't mean to send it out for review just yet. |
added 2 commits
December 1, 2025 18:49
…existing generated files; wrap topic file and config traversal in reusable function
Contributor
petedannemann
left a comment
There was a problem hiding this comment.
Looks pretty good, left two minor comments
Co-authored-by: Peter Dannemann <28637185+petedannemann@users.noreply.github.com>
hhahn-tw
requested changes
Dec 3, 2025
Contributor
|
Please also provide update the README outlining this new feature |
added 2 commits
December 4, 2025 10:07
…thub.com/segmentio/topicctl into TUBE-3309/rebalaing-topcis-wo-config-files
Co-authored-by: Peter Dannemann <28637185+petedannemann@users.noreply.github.com>
petedannemann
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
--generate-configflag for therebalancecommand.The flag would update the main process as outlined below:
This PR also adds a wrapper function around the traversal of topic configs for reusability purposes.
Notes
bootstrapcommand in a limited capacity. We could potentially add support for all of the bootstrap arguments but that's outside the scope of this featureTesting
$ topicctl get balance 'check-topic--JNKfqh' --zk-addr=localhost:2181Broker replicas:
Broker rack replicas:
Manually bootstrapped check-topic--JNKfqh in order to remove one broker
$ topicctl apply 'examples/local-cluster/topics/check-topic--JNKfqh.yaml' --rebalance --to-remove 1$ topicctl get balance 'check-topic--JNKfqh' --zk-addr=localhost:2181Broker replicas:
Broker rack replicas:
Deleted manually bootstrapped topic config
$ topicctl rebalance --cluster-config='examples/local-cluster/cluster.yaml' --path-prefix='examples/local-cluster/topics' --bootstrap-missing-configsBroker replicas:
Broker rack replicas: