support consumer groups in tail config#180
Open
isaacd9 wants to merge 3 commits intosegmentio:masterfrom
Open
Conversation
Contributor
|
Hello - thanks for the contribution. While the command line form seems to work as expected, I'm having trouble with the repl form. When running eg. Without the Can you clarify what may be wrong? Separately - can you update the help text for the repl form to include the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support consumer groups in tail.
Adds an argument to
topicctl tailto support a consumer group--group-id. If set, this disables the partitions command is passed down to the reader.I also updated
replwith this.I'm happy to write a test for this but would love some instruction on the preferred way to do so in this repo.