Repository navigation
fix(status): return 400 for codes outside 100-999 - #36
Merged
Merged
Conversation
s3anw3
approved these changes
Nov 7, 2026
s3anw3
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix! Validating codes in the shared parser correctly rejects out-of-range values before selection and covers both GET and POST, including comma-separated lists. The added regression test covers the reported cases. Local validation passed: 275 library tests, including one additional review-only test. No blocking findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35
/status/99and/status/1000used to come back as200 OKbecauseStatusCode::from_u16fails and the handlers fall back toStatusCode::OK. This adds a range check inparse_weighted_codes, so these codes now get the same400 {"error": "Invalid status code"}already used for unparsable codes (matching httpbin). It covers both the GET and POST handlers and comma-separated lists too.Added a test for 99, 1000, 0 and
200,1000on GET and POST.cargo test,cargo fmt --checkandcargo clippyall pass locally.Thanks for taking a look!