[UI][Map] Show region rating and agent count#5469
Conversation
|
Hey @carboncowboy - thank you for the contribution. This looks similar to Alchemy's implementation. Did you happen to review their implementation in the process? I was just looking around at their implementation here: https://github.com/AlchemyViewer/Alchemy/blob/develop/indra/newview/llworldmapview.cpp#L528 I did notice you have some distinction here - notably adding a fallback for when the grid name is empty. |
I wrote up a spec based on the behavior I saw in Alchemy and FS and had Cursor implement the feature --then went through some revisions to make sure it was acceptable code quality wise. |
|
Thank you for clarifying @carboncowboy. Upon closer review - this seems more or less very mildly reformatted from Alchemy's implementation. As a result, I don't think we'll be accepting this given the stark similarities to Alchemy's implementation. I would reach out to Rye - see if he'd like to contribute it or ask permission to rather than pointing an LLM at it and having it make some minor revisions to it. Rye wrote that code, so it's only fair to involve him in the process of getting this contributed upstream. |
Show maturity rating (PG/M/A) and agent count on world map region labels, example: RegionName (17) (A) for online regions and RegionName (offline) (M) for offline. This matches behavior in many third-party viewers (Firestorm, Alchemy, etc.) and makes it easier to see region maturity and population at a glance.
Closes #5467