Repository navigation
Conversation
Currently when stopping AsyncSniffer there is no easy way to tell whether the sniffer just was already stopped or some other error occured. Add separate ScapyNotRunningException for that. AI-Assisted: no
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5258 +/- ##
=======================================
Coverage 80.54% 80.55%
=======================================
Files 375 375
Lines 98399 98401 +2
=======================================
+ Hits 79259 79265 +6
+ Misses 19140 19136 -4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add ScapyNotRunningException
Currently when stopping AsyncSniffer there is no easy way to tell whether the sniffer just was already stopped or some other error occured. Add separate ScapyNotRunningException for that.
I have to use
Very not nice and fragile...
Maybe I've missed some better way?
I've put
AI-Assisted: noas I used Claude Opus 5.5 only as reviewer and I expect that it is needed to discern generated code, not review etc. It would be helpful if more details are given inCONTRIBUTING.md, please write if I'm mistaken.