Fix bare except clause in setup.py#5051
Open
koteshyelamati wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for the PR, please fix the commit validity check. |
Author
|
Thank you for the review, @polybassa! Could you clarify what the commit validity check requires? I see the "Check the validity of the commits" CI check is failing — is this a DCO sign-off ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace bare
except:withexcept ImportError:insetup.py.The guarded block imports from
setuptools— specificallyfrom setuptools import .... The only exception that can reasonably be raised here isImportError(when setuptools is not installed). Usingexcept ImportError:makes the intent explicit and avoids accidentally swallowingKeyboardInterruptorSystemExit.