Skip to content

ci: exclude failsafe summaries from JUnit reports - #1012

Merged
dkropachev merged 2 commits into
scylladb:scylla-4.xfrom
dkropachev:fix/junit-report-test-xml-only
Aug 20, 2026
Merged

ci: exclude failsafe summaries from JUnit reports#1012
dkropachev merged 2 commits into
scylladb:scylla-4.xfrom
dkropachev:fix/junit-report-test-xml-only

Conversation

@dkropachev

Copy link
Copy Markdown

Moves the CI-only report filtering change out of #999.

Restricts test report publication to TEST-*.xml, excluding Maven Failsafe summary XML files that are not JUnit testcase reports.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: c0a047db-6902-4c91-a974-cb4a2f871c1e

📥 Commits

Reviewing files that changed from the base of the PR and between ee0d033 and d8f6dd3.

📒 Files selected for processing (1)
  • .github/workflows/tests@v1.yml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • scylladb/scylladb (auto-detected)
  • scylladb/github-automation (auto-detected)

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The workflow removes temporary report-copy steps from unit, Cassandra integration, and Scylla integration jobs. Artifact uploads use the configured report paths directly. Integration-result uploads require both workflow failure and integration-test step failure. JUnit parsing now matches only TEST-*.xml files.

Merge Risk: ⚪ Minimal · up to d8f6d

This change narrowly limits CI report publication to JUnit testcase files, and no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description directly explains the CI report filtering and artifact upload changes.
Title check ✅ Passed The title clearly identifies the primary CI change: excluding Failsafe summaries from JUnit reports.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@nikagra nikagra left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST-* is the right filter here — the action reads report_paths with getMultilineInput and treats each line as its own report, so a !failsafe-summary* line can't subtract from another pattern.

Adjacent, not this PR's job: the IT Copy/Upload test results steps (269/276, 389/397) use if: steps.run-integration-tests.outcome == 'failure', which Actions expands to success() && … — unsatisfiable, so failing IT lanes upload no reports at all (job 96084472915: both steps skipped while Upload CCM logs, on if: failure(), ran).

Comment thread .github/workflows/tests@v1.yml

@nikagra nikagra left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — both notes above are pre-existing and out of scope for this extraction.

Remove redundant report copies that caused unit-test results to be uploaded twice. Ensure Cassandra and Scylla integration-test artifacts are uploaded after failed test steps by using an explicit failure condition.
@dkropachev
dkropachev merged commit d8f6dd3 into scylladb:scylla-4.x Aug 20, 2026
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants