ci: exclude failsafe summaries from JUnit reports - #1012
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe workflow removes temporary report-copy steps from unit, Cassandra integration, and Scylla integration jobs. Artifact uploads use the configured report paths directly. Integration-result uploads require both workflow failure and integration-test step failure. JUnit parsing now matches only Merge Risk: ⚪ Minimal · up to This change narrowly limits CI report publication to JUnit testcase files, and no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
nikagra
left a comment
There was a problem hiding this comment.
TEST-* is the right filter here — the action reads report_paths with getMultilineInput and treats each line as its own report, so a !failsafe-summary* line can't subtract from another pattern.
Adjacent, not this PR's job: the IT Copy/Upload test results steps (269/276, 389/397) use if: steps.run-integration-tests.outcome == 'failure', which Actions expands to success() && … — unsatisfiable, so failing IT lanes upload no reports at all (job 96084472915: both steps skipped while Upload CCM logs, on if: failure(), ran).
nikagra
left a comment
There was a problem hiding this comment.
LGTM — both notes above are pre-existing and out of scope for this extraction.
Remove redundant report copies that caused unit-test results to be uploaded twice. Ensure Cassandra and Scylla integration-test artifacts are uploaded after failed test steps by using an explicit failure condition.
Moves the CI-only report filtering change out of #999.
Restricts test report publication to
TEST-*.xml, excluding Maven Failsafe summary XML files that are not JUnit testcase reports.