Skip to content

fix: report TLS from active channel handlers - #1011

Open
dkropachev wants to merge 1 commit into
scylladb:scylla-4.xfrom
dkropachev:fix/report-tls-from-active-channel
Open

fix: report TLS from active channel handlers#1011
dkropachev wants to merge 1 commit into
scylladb:scylla-4.xfrom
dkropachev:fix/report-tls-from-active-channel

Conversation

@dkropachev

Copy link
Copy Markdown

Moves active-channel TLS detection out of #999.

The configuration report now derives whether TLS is enabled from the control channel pipeline after NettyOptions.afterChannelInitialized, so custom hooks that add or remove an SslHandler are reflected accurately. Hostname-verification behavior is otherwise unchanged.

Tests:

  • mvn -pl core -DskipITs -Dtest=DefaultDriverConfigReporterTest,ProtocolInitHandlerTest test

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@dkropachev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 33 minutes

Limit details: You’ve used all 3 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: 29fe1988-56aa-4876-ba46-41123f020225

📥 Commits

Reviewing files that changed from the base of the PR and between ee0d033 and 4618c81.

📒 Files selected for processing (7)
  • core/src/main/java/com/datastax/oss/driver/internal/core/channel/ProtocolInitHandler.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/context/DefaultDriverConfigReporter.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/context/DriverConfigReporter.java
  • core/src/main/java/com/datastax/oss/driver/internal/core/context/NoopDriverConfigReporter.java
  • core/src/test/java/com/datastax/oss/driver/internal/core/channel/ChannelFactoryTestBase.java
  • core/src/test/java/com/datastax/oss/driver/internal/core/channel/ProtocolInitHandlerTest.java
  • core/src/test/java/com/datastax/oss/driver/internal/core/context/DefaultDriverConfigReporterTest.java

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant