Skip to content

test: skip the third WarningsTest method under Scylla - #1003

Merged
dkropachev merged 1 commit into
scylladb:scylla-3.xfrom
nikagra:fix/warningstest-scyllaskip
Aug 17, 2026
Merged

test: skip the third WarningsTest method under Scylla#1003
dkropachev merged 1 commit into
scylladb:scylla-3.xfrom
nikagra:fix/warningstest-scyllaskip

Conversation

@nikagra

@nikagra nikagra commented Aug 14, 2026

Copy link
Copy Markdown

WarningsTest has three tests, all requiring the server to emit Cassandra's "Aggregation query used without partition key" warning for SELECT count(*) FROM foo. Scylla does not send it. Two were annotated in f475ebd "Disable ITs which fail under Scylla"; this one was missed. Annotate it too.

Why it was missed, and why it surfaced now:

Date Commit Effect
2021-09-06 f475ebd @ScyllaSkip on the two short-group methods. This one is groups = "isolated", which was not being run — so it was never observed to fail
2026-06-26 scylla-java-driver-matrix 9889882 Adds -Pisolated for 3.x tags; the method executes against Scylla for the first time, and fails
2026-07-09 scylla-java-driver-matrix 33a4459 Worked around in versions/scylla/3.11.5.16/patch rather than fixed here

Same shape as #1000: a latent test defect masked because the assertion was never really exercised, surfaced by a harness change, then patched per-version in the matrix instead of at source.

Nothing to fix driver-side — ExecutionInfo.getWarnings() correctly reports that the server sent no warning. Annotating here makes the file self-consistent and means future tags need no patch hunk.

Not rewritten to assert a warning Scylla does emit (e.g. the RF-below-minimum_replication_factor_warn_threshold one). That would restore genuine coverage of DISABLE_QUERY_WARNING_LOGS — currently zero on Scylla across all three methods — but depends on a config-dependent trigger of unproven stability across versions. Worth a separate ticket.

No matrix-repo change: both currently-tested 3.x versions already suppress this (3.11.4.0 via ignore.yaml, 3.11.5.17 via fallback to 3.11.5.16's patch).

🤖 Generated with Claude Code

All three tests in WarningsTest require the server to emit Cassandra's
"Aggregation query used without partition key" warning for SELECT count(*),
which Scylla does not send. Two were annotated in "Disable ITs which fail
under Scylla" (f475ebd); this one was missed because its `isolated` group
was not run at the time, so it was never observed to fail. The matrix started
running that group in June 2026, and the failure has since been worked around
in a single version's patch file rather than fixed here.

Annotate it like its two siblings so the file is self-consistent and future
tags need no patch hunk. Nothing to fix driver-side: getWarnings() correctly
reports that the server sent no warning.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Pro Plus

Run ID: fe437165-42d0-491a-bbd3-da522746fbf0

📥 Commits

Reviewing files that changed from the base of the PR and between a75a7ca and 4d33a2c.

📒 Files selected for processing (1)
  • driver-core/src/test/java/com/datastax/driver/core/WarningsTest.java
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • scylladb/github-automation (auto-detected)
  • scylladb/scylladb (auto-detected)

📝 Walkthrough

Walkthrough

The should_execute_query_and_not_log_server_side_warnings test in WarningsTest now has the @ScyllaSkip annotation.

Merge Risk: ⚪ Minimal · up to 4d33a

This change only skips a Scylla-incompatible test method, with no production behavior impact; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the test change and the Scylla-specific behavior.
Description check ✅ Passed The description accurately explains why the third test requires the same Scylla skip as the other two tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@nikagra
nikagra requested a review from dkropachev August 17, 2026 13:13
@dkropachev
dkropachev merged commit d88197e into scylladb:scylla-3.x Aug 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants