test: skip the third WarningsTest method under Scylla - #1003
Merged
dkropachev merged 1 commit intoAug 17, 2026
Conversation
All three tests in WarningsTest require the server to emit Cassandra's "Aggregation query used without partition key" warning for SELECT count(*), which Scylla does not send. Two were annotated in "Disable ITs which fail under Scylla" (f475ebd); this one was missed because its `isolated` group was not run at the time, so it was never observed to fail. The matrix started running that group in June 2026, and the failure has since been worked around in a single version's patch file rather than fixed here. Annotate it like its two siblings so the file is self-consistent and future tags need no patch hunk. Nothing to fix driver-side: getWarnings() correctly reports that the server sent no warning. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthroughThe Merge Risk: ⚪ Minimal · up to This change only skips a Scylla-incompatible test method, with no production behavior impact; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
dkropachev
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WarningsTesthas three tests, all requiring the server to emit Cassandra's"Aggregation query used without partition key"warning forSELECT count(*) FROM foo. Scylla does not send it. Two were annotated in f475ebd "Disable ITs which fail under Scylla"; this one was missed. Annotate it too.Why it was missed, and why it surfaced now:
@ScyllaSkipon the twoshort-group methods. This one isgroups = "isolated", which was not being run — so it was never observed to fail9889882-Pisolatedfor 3.x tags; the method executes against Scylla for the first time, and fails33a4459versions/scylla/3.11.5.16/patchrather than fixed hereSame shape as #1000: a latent test defect masked because the assertion was never really exercised, surfaced by a harness change, then patched per-version in the matrix instead of at source.
Nothing to fix driver-side —
ExecutionInfo.getWarnings()correctly reports that the server sent no warning. Annotating here makes the file self-consistent and means future tags need no patch hunk.Not rewritten to assert a warning Scylla does emit (e.g. the RF-below-
minimum_replication_factor_warn_thresholdone). That would restore genuine coverage ofDISABLE_QUERY_WARNING_LOGS— currently zero on Scylla across all three methods — but depends on a config-dependent trigger of unproven stability across versions. Worth a separate ticket.No matrix-repo change: both currently-tested 3.x versions already suppress this (
3.11.4.0viaignore.yaml,3.11.5.17via fallback to3.11.5.16's patch).🤖 Generated with Claude Code