Skip to content

Conversation

@keller-mark
Copy link
Contributor

This PR clarifies how to access the attributes listed here when accessing the points data from the on-disk format.

Is this correct that the coordinate transformations are in "transform" in-memory but "coordinateTransformations" on-disk?

@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.20%. Comparing base (7604a3d) to head (73b0c76).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
+ Coverage   92.14%   92.20%   +0.06%     
==========================================
  Files          48       49       +1     
  Lines        7473     7560      +87     
==========================================
+ Hits         6886     6971      +85     
- Misses        587      589       +2     

see 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@keller-mark keller-mark marked this pull request as ready for review July 30, 2025 22:20
@keller-mark keller-mark changed the title Add note about on-disk locations of point attributes Design doc: Add note about on-disk locations of point attributes Jul 30, 2025
@keller-mark keller-mark changed the title Design doc: Add note about on-disk locations of point attributes Design doc: Add note about on-disk locations of point metadata attributes Jul 30, 2025
@LucaMarconato
Copy link
Member

Thanks @keller-mark for helping clarifying the design doc. I edited a bit and I will merge.

Now that Zarr v3 is supported the location of where coordinate transformations are saved on disk changed a bit (it's inside a ome group). Furthermore the latest version of the NGFF coordinate transformations RFC introduces extra changes in how the transformation metadata should be written (we plan to introduce these changes soon). So I replaced your edit regarding where coordinate transformations are stored on disk by saying that we will follow the NGFF specs.

@LucaMarconato LucaMarconato merged commit 50df838 into scverse:main Jan 4, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants