Repository navigation
Conversation
…iew would be clipped by the table's scroll container
…utside the table's scroll container; printing shows them below the table
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Footnote previews inside a table were clipped: the theme wraps every table in a scroll container (
overflow: auto, so wide tables scroll sideways), and the hover preview is positioned inside it. Seen on the compatibility matrix in #76 / #77, whose footnotes sit in the outer columns.Now the previews of a table's footnotes are placed relative to the viewport (
position: fixedwith CSS anchor positioning), at their reference, so the scroll container no longer clips them: below the reference, or above it if there is no room, and shifted sideways to stay on screen. Still CSS only.In print, a footnote referenced from a table shows right below that table, as a table note, instead of in the "Notes" at the end of the page. Browsers without anchor positioning show these table notes on screen too, instead of the previews. Footnotes in running text are unchanged. If a page's "Notes" section loses all its footnotes this way, it stays hidden.
Checked with a local build of #76 in Chrome 156 (light and dark theme, 390 px wide, print): the previews in the compatibility matrix show in full above the table, the table note shows only in print, and the 21 previews of
storage-formatare unchanged.Before / after
Compatibility matrix from #76, hovering the first footnote reference (Chrome, 1400 px wide).