Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
==========================================
+ Coverage 75.39% 75.61% +0.22%
==========================================
Files 10 10
Lines 2906 2908 +2
Branches 672 672
==========================================
+ Hits 2191 2199 +8
+ Misses 431 428 -3
+ Partials 284 281 -3
🚀 New features to boost your workflow:
|
a782851 to
bfb1ef2
Compare
… index (#358) When points have a shuffled or non-sequential index (e.g. from .sample() or .subset()), _reparse_points sorts rows by index while adata.X retains the original order. This causes get_values to return colors in sorted order, misaligned with coordinates. Resetting the index to sequential before adata construction and reparsing ensures both share the same positional order. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bfb1ef2 to
d3ca5ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.sample()or.subset()), categorical colors were assigned based on sorted index order instead of actual row order, causing colors to appear shuffled._reparse_points()round-trips throughPointsModel.parsewhich sorts by index, butadata.Xretained the original unsorted order.get_values()then returned colors in sorted order — misaligned with coordinates.