Skip plt.show() when user supplies ax= to allow multi-call layering#569
Merged
Skip plt.show() when user supplies ax= to allow multi-call layering#569
Conversation
…362) When show=None (default) and the user provides their own axes via ax=, default show to False instead of auto-detecting interactive mode. This allows multiple .pl.show(ax=...) calls to accumulate content on the same axes without plt.show() consuming the figure in between. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
==========================================
+ Coverage 75.39% 75.47% +0.07%
==========================================
Files 10 10
Lines 2906 2907 +1
Branches 672 672
==========================================
+ Hits 2191 2194 +3
Misses 431 431
+ Partials 284 282 -2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
show=None(default) and the user provides their own axes viaax=, defaultshowtoFalseinstead of auto-detecting interactive mode..pl.show(ax=...)calls to accumulate content on the same axes withoutplt.show()consuming the figure in between.Closes #362. Also addresses the root cause of #71.