Fix datashader ignoring na_color transparency for continuous data#566
Merged
Fix datashader ignoring na_color transparency for continuous data#566
Conversation
#565) When na_color is fully transparent (alpha="00"), skip the NaN overlay entirely in the datashader continuous path for both shapes and points. Previously, _hex_no_alpha stripped the alpha channel before passing to ds.tf.shade, turning transparent "#d3d3d300" into opaque "#d3d3d3". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
==========================================
+ Coverage 74.06% 75.10% +1.04%
==========================================
Files 10 10
Lines 2826 2876 +50
Branches 651 664 +13
==========================================
+ Hits 2093 2160 +67
+ Misses 457 431 -26
- Partials 276 285 +9
🚀 New features to boost your workflow:
|
Add is_fully_transparent() method to Color class and use it across all 5 call sites. Parametrize duplicate shapes tests and tighten docstrings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
na_color=None(fully transparent), the datashader continuous path for shapes and points now skips the NaN overlay entirely instead of rendering opaque grey shapes._hex_no_alpha()stripped the alpha channel fromna_colorbefore passing tods.tf.shade(), turning transparent"#d3d3d300"into opaque"#d3d3d3".