Skip to content

chore: Update DL notebook#26

Open
ilan-gold wants to merge 20 commits into
mainfrom
ig/annbatch
Open

chore: Update DL notebook#26
ilan-gold wants to merge 20 commits into
mainfrom
ig/annbatch

Conversation

@ilan-gold

Copy link
Copy Markdown
Contributor

That was painful! But the accuracy is better than the last notebook so I think it went alright!

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ilan-gold ilan-gold requested a review from Zethson June 12, 2026 15:27
Comment thread annbatch.ipynb
Comment thread annbatch.ipynb
Comment thread annbatch.ipynb
Comment thread annbatch.ipynb
Comment thread annbatch.ipynb
@@ -0,0 +1,1978 @@
{

@Zethson Zethson Jun 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #1.    covid = sc.read('covid_cite.h5ad')

Put this onto our S3 (all of our datasets should be there) and use the backup URL thingy of read,please.


Reply via ReviewNB

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, what is a "URL thingy of read"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. No I just went with a pooch downloader, sorry I assumed this was pointing at gdown.

Comment thread annbatch.ipynb
Comment thread annbatch.ipynb
Comment thread annbatch.ipynb
@@ -0,0 +1,1978 @@
{

@Zethson Zethson Jun 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #6.        for batch in train_loader:

This whole section is very long. Can we reduce it?


Reply via ReviewNB

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is important because it shows how to work with the loader output. Isn't that the point?

Comment thread annbatch.ipynb
@@ -0,0 +1,1978 @@
{

@Zethson Zethson Jun 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use hide-output,please.


Reply via ReviewNB

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's pretty common to print this as a sanity check.

Comment thread annbatch.ipynb
@ilan-gold ilan-gold requested a review from Zethson June 12, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants