Skip to content

feat: finalize floating keyboard option (#663) - #664

Merged
andrewtavis merged 2 commits into
scribe-org:mainfrom
prince-0408:main
Aug 6, 2026
Merged

feat: finalize floating keyboard option (#663)#664
andrewtavis merged 2 commits into
scribe-org:mainfrom
prince-0408:main

Conversation

@prince-0408

Copy link
Copy Markdown
Collaborator

Description

This PR finalizes the floating keyboard feature as requested in #663 by updating the float toggle key icon behavior and removing obsolete layout setting options.

Key Changes

  1. Dynamic Floating Key Icon:

    • Updated ic_keyboard_dismiss.xml vector drawable to represent a down chevron inside a square frame.
    • Updated KeyboardView.kt so that when KeyboardBase.KEYCODE_FLOAT_TOGGLE is drawn, it dynamically shows:
      • Down chevron in a square (ic_keyboard_dismiss) when the keyboard is currently in floating mode.
      • Move/float icon (ic_float_keyboard) when the keyboard is docked.
  2. UI & Preferences Cleanup:

    • Removed obsolete "Floating key on keyboard" layout switch option from LanguageSettingsScreen.kt.
    • Removed obsolete "Clipboard key on keyboard" layout preference options from LanguageSettingsScreen.kt.
    • Cleaned up PreferencesHelper.kt by removing FLOATING_KEY_ON_KEYBOARD and CLIPBOARD_KEY_ON_KEYBOARD constants, setters, and getters.
    • Removed isFloatingKeyEnabled() and isClipboardKeyEnabled() methods from KeyboardContextProvider interface in KeyboardBase.kt and GeneralKeyboardIME.kt.
    • Cleaned up unused string resources in strings.xml.

Related Issue

Closes #663

Verification & Testing

  • Automated Gradle build test passed cleanly via ./gradlew assembleDebug.
  • Verified string resources and UI layout settings screen compiling without lint errors.

Screenshots

Floating mode down chevron in square key icon Docked mode float key icon

@prince-0408
prince-0408 requested a review from andrewtavis August 6, 2026 09:47

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: All's really great here, @prince-0408! Really thanks so much for the quick reaction and the clean up here! 😊

@andrewtavis
andrewtavis merged commit 0c0b4fd into scribe-org:main Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finalize floating keyboard option

2 participants