feat: finalize floating keyboard option (#663) - #664
Merged
Conversation
andrewtavis
approved these changes
Aug 6, 2026
andrewtavis
left a comment
Member
There was a problem hiding this comment.
praise: All's really great here, @prince-0408! Really thanks so much for the quick reaction and the clean up here! 😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR finalizes the floating keyboard feature as requested in #663 by updating the float toggle key icon behavior and removing obsolete layout setting options.
Key Changes
Dynamic Floating Key Icon:
ic_keyboard_dismiss.xmlvector drawable to represent a down chevron inside a square frame.KeyboardView.ktso that whenKeyboardBase.KEYCODE_FLOAT_TOGGLEis drawn, it dynamically shows:ic_keyboard_dismiss) when the keyboard is currently in floating mode.ic_float_keyboard) when the keyboard is docked.UI & Preferences Cleanup:
LanguageSettingsScreen.kt.LanguageSettingsScreen.kt.PreferencesHelper.ktby removingFLOATING_KEY_ON_KEYBOARDandCLIPBOARD_KEY_ON_KEYBOARDconstants, setters, and getters.isFloatingKeyEnabled()andisClipboardKeyEnabled()methods fromKeyboardContextProviderinterface inKeyboardBase.ktandGeneralKeyboardIME.kt.strings.xml.Related Issue
Closes #663
Verification & Testing
./gradlew assembleDebug.Screenshots