Open
Conversation
BMagnu
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revamps the fullneb configuration from near and far multipliers with fixed nebula transparencies to a much more intuitive near-distance + configurable transparency at 1000m depth. It furthermore adds clip distances after which the nebula does not gain opacity with more depth, split between skyboxes and everything else. This is needed, and accordingly default-configured for old missions, because prior to #7245, skybox depth was incorrectly clipped to 0 in the shader due to float overflow, resulting in non-fogged skyboxes. #7245 fixed that, and in turn made skyboxes get fogged with full opacity, essentially completely hiding them when fog is enabled.
This PR makes the respective values fully configurable, allowing for full fogging, no fogging, and anything inbetween for skyboxes and/or ships respectively.
Note that this is the main conversion and bugfix first, the actual FRED-Dialogue for configuring the new-type values is outstanding and will follow in a future PR as to not delay this bugfix