Conversation
82e332d to
ec76cc1
Compare
|
Does adding comments to nodes, then deleting and readding nodes result in comments being incorrectly placed? More specifically, with this update it looks like |
Good catch. I have committed a fix for this so that free_node2() will now clear annotations if we're using a version of the model that's annotations-enabled. |
b9312b9 to
ab5363a
Compare
ab5363a to
7b91af1
Compare
This is the long-promised sexp_tree refactor. The main goal was to move all logic out of FRED's sexp_tree.cpp into a model that could be shared between both FRED and QtFRED. This would not only simplify how much duplicate maintenance we have to do but would also open up sexp editing to new kinds of UIs layered on top (such as the graph editor as requested in #4809 .
The model ended up being split into 4 files: the main sexp tree model, an actions helper, an OPF helper, and an Event Annotations model. While reviewing it may be helpful to start with the main model, then actions and opf, then events. Then with that knowledge take a look at the old sexp_tree files (renamed to sexp_tree_view).
I'm making builds of FRED available to mission designers for testing as well while the review process gets under way.
Because of how intertwined the logic and UI was in sexp_tree I did not see an easy way to split this up into manageable pieces. I'm so sorry.
Fixes #6982