Open
Conversation
MjnMixael
force-pushed
the
builtin_photo_mode
branch
from
d8b8946 to
9866314
Compare
wookieejedi
reviewed
Mar 18, 2026
MjnMixael
force-pushed
the
builtin_photo_mode
branch
from
9866314 to
ee1015a
Compare
MjnMixael
force-pushed
the
builtin_photo_mode
branch
from
ee1015a to
ac62baf
Compare
wookieejedi
reviewed
Apr 1, 2026
wookieejedi
reviewed
Apr 1, 2026
wookieejedi
reviewed
Apr 1, 2026
Member
|
Thanks for all the updates and incorporations, especially the controls bitmap aspects! It looks good to me, though given this new change I'll give folks at least a few days to look it over before merging. |
wookieejedi
approved these changes
Apr 4, 2026
Member
wookieejedi
left a comment
wookieejedi
left a comment
There was a problem hiding this comment.
Per previous comments I'm approving and will merge tomorrow evening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an in-engine photo mode that creates a controllable camera that obeys flight control keybinds. The photo mode comes with a togglable rule-of-thirds grid and adjustable filters (saturation, brightness, contrast).
There is a sexp to disallow photo mode (it's always disallowed in multiplayer) and the camera sexps automatically disable/enable photo mode as well.
This also comes with scripting hooks for photo mode started and ended.
EDIT: Per the conversation with Wookie I have modified this PR to make the controls system as it relates to photo mode much cleaner. I have added a conflicts bitmask to the control bindings data which is meant to distinguish between bindings used for entirely different gameplay states (not proper STATES) but like normal flight vs photo mode. This allows 2 things very easily. First, any binding not related to photo mode while in photo mode is entirely ignored automatically (and vice versa). Second, it allows photo mode controls to share keys with non-photo mode controls. That in turn allows photo mode to use the arrow keys by default for effect modification which is a much nicer user experience. The keybind for toggling photo mode has both bits set so it conflicts with both photo mode keys and normal keys and is never ignored in these states. I've no idea how this could be used in the future but it could theoretically be easily expanded if needed for other sets of keybind conflict groups.