fix: use if [[ $flag ]] for IFS-safe boolean tests - #931
Merged
Conversation
akinomyoga
marked this pull request as draft
April 22, 2023 03:56
akinomyoga
force-pushed
the
boolean2
branch
2 times, most recently
from
April 22, 2023 04:15
eab5952 to
57ff117
Compare
akinomyoga
marked this pull request as ready for review
April 22, 2023 04:16
scop
reviewed
Apr 22, 2023
This was referenced Apr 22, 2023
akinomyoga
force-pushed
the
boolean2
branch
3 times, most recently
from
April 22, 2023 18:04
f76b13a to
238fef0
Compare
Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. #914 (comment)