Conversation
There was a problem hiding this comment.
CI doesn't currently handle adding new images properly, so I'm seeding ghcr.io/scop/bash-completion/test:almalinux9 by pushing my locally built image.
e29591b to
4b4ab7f
Compare
Mostly for Bash 5.1 test coverage, and likely eventual CentOS 7 replacement.
4b4ab7f to
733b0f1
Compare
|
Quite a few errors/failures in the first run. Messy notes from my local run that I have not sorted through. $ docker run --rm -t -v $PWD:/usr/src/bash-completion -w /usr/src/bash-completion ghcr.io/scop/bash-completion/test:almalinux9 test/docker/entrypoint.shDetailsbsdtar test_readable_archives, test_writable_archives javadoc test_4_comp_dequote_incomplete 7z: test_6 python3: test_bb rsync test_1, test_local_path_with_spaces, test_remote_path_with_spaces lvextend test_1 timeout sshfs test_1, test_local_path_suffix_1, test_remote_path_ending_with_backslash unit_get_cword test_25 TBD screen test_1, test_2, test_3, test_4, test_5, test_telnet, test_serial_3rdplus_arg, test_local_path_with_spaces_2 timeout scp test_option_arg, test_remote_path_with_nullglob, test_remote_path_with_failglob, test_remote_path_with_spaces, test_remote_path_with_backslash, test_remote_path_with_backslash_2, test_local_path_ending_with_backslash, test_remote_path_ending_with_backslash, test_local_path_with_spaces_1, test_local_path_backslash timeout |
|
Can't seem to reproduce any of those failures in a plain interactive run, like |
|
Seems the tests are flaky, getting random different errors across runs with plain in an interactive container. Tried also running the orignal tests without |
|
Ok, two classes of problems here:
So in that sense I consider this PR to be actually mergeable as is. |
Mostly for Bash 5.1 test coverage, and likely eventual CentOS 7 replacement.