Skip to content

refactor: adjust API/naming of generators - #1029

Merged
scop merged 5 commits into
scop:masterfrom
akinomyoga:fixup-api-renaming
Sep 7, 2023
Merged

refactor: adjust API/naming of generators#1029
scop merged 5 commits into
scop:masterfrom
akinomyoga:fixup-api-renaming

Conversation

@akinomyoga

@akinomyoga akinomyoga commented Aug 6, 2023

Copy link
Copy Markdown
Collaborator

Changes on top of #1028 / Should be considered after merging #1028

@akinomyoga akinomyoga changed the title [WIP] small fixes [Waiting for #1028] refactor: adjust API/naming of generators Aug 13, 2023
Comment thread bash_completion
scop added a commit that referenced this pull request Aug 20, 2023
@akinomyoga

Copy link
Copy Markdown
Collaborator Author

Rebased.

@akinomyoga
akinomyoga force-pushed the fixup-api-renaming branch 2 times, most recently from 68323e4 to 31e0295 Compare August 26, 2023 11:55
@akinomyoga akinomyoga changed the title [Waiting for #1028] refactor: adjust API/naming of generators refactor: adjust API/naming of generators Aug 26, 2023
@akinomyoga
akinomyoga marked this pull request as ready for review August 26, 2023 17:37

@scop scop left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@scop
scop merged commit 7881365 into scop:master Sep 7, 2023
@akinomyoga
akinomyoga deleted the fixup-api-renaming branch September 9, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants