Skip to content

Fix Python calling and enable CI=true#528

Open
phracek wants to merge 4 commits intomasterfrom
enable_ci_true
Open

Fix Python calling and enable CI=true#528
phracek wants to merge 4 commits intomasterfrom
enable_ci_true

Conversation

@phracek
Copy link
Member

@phracek phracek commented Feb 24, 2026 •
edited by github-actions bot
Loading

Enable CI=true in NodeJS directly

@pacostas Please review it.
Thanks.

@phracek
Fix Python calling and enable CI=true
575b6e6 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Feb 24, 2026

[test-upstream]

@phracek
Copy link
Member Author

phracek commented Feb 24, 2026

[test-pytest]

@github-actions
Copy link

github-actions bot commented Feb 24, 2026

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - UpstreamTests - 22-minimalFedora-latestx86_64✅ passed24.02.2026 14:44:024min 32stest pipeline

@github-actions
Copy link

github-actions bot commented Feb 24, 2026 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - UpstreamTests - 20-minimalFedora-latestx86_64✅ passed25.02.2026 12:48:155min 47stest pipeline
Fedora - UpstreamTests - 24-minimalFedora-latestx86_64✅ passed26.02.2026 18:26:406min 15stest pipeline
CentOS Stream 10 - UpstreamTests - 24-minimalCentOS-Stream-10x86_64✅ passed26.02.2026 18:26:538min 53stest pipeline
CentOS Stream 10 - UpstreamTests - 22-minimalCentOS-Stream-10x86_64✅ passed26.02.2026 18:26:249min 40stest pipeline
CentOS Stream 10 - UpstreamTests - 22CentOS-Stream-10x86_64✅ passed27.02.2026 07:43:3924min 8stest pipeline
CentOS Stream 9 - UpstreamTests - 24CentOS-Stream-9x86_64✅ passed26.02.2026 18:26:2524min 23stest pipeline
Fedora - UpstreamTests - 20Fedora-latestx86_64❌ error25.02.2026 12:55:1424min 9stest pipeline
Fedora - UpstreamTests - 22Fedora-latestx86_64❌ error25.02.2026 13:00:3820min 37stest pipeline
Fedora - UpstreamTests - 24Fedora-latestx86_64✅ passed26.02.2026 18:26:2421min 6stest pipeline
CentOS Stream 10 - UpstreamTests - 24CentOS-Stream-10x86_64✅ passed26.02.2026 18:35:0024min 18stest pipeline
CentOS Stream 9 - UpstreamTests - 24-minimalCentOS-Stream-9x86_64✅ passed26.02.2026 18:26:239min 8stest pipeline
Fedora - PyTest - 20-minimalFedora-latestx86_64✅ passed24.02.2026 15:08:2814min 26stest pipeline
CentOS Stream 9 - UpstreamTests - 20-minimalCentOS-Stream-9x86_64✅ passed26.02.2026 18:26:239min 56stest pipeline
RHEL8 - UpstreamTests - 22-minimalRHEL-8.10.0-Nightlyx86_64✅ passed26.02.2026 18:26:3213min 44stest pipeline
RHEL8 - UpstreamTests - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed26.02.2026 18:37:0514min 43stest pipeline
RHEL10 - UpstreamTests - 22-minimalRHEL-10-Nightlyx86_64✅ passed26.02.2026 18:26:2311min 54stest pipeline
RHEL10 - UpstreamTests - 24RHEL-10-Nightlyx86_64✅ passed26.02.2026 18:26:3030min 55stest pipeline
RHEL10 - UpstreamTests - 24-minimalRHEL-10-Nightlyx86_64✅ passed26.02.2026 18:26:2211min 28stest pipeline
RHEL9 - UpstreamTests - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 18:26:2317min 28stest pipeline
RHEL9 - UpstreamTests - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 07:46:1316min 46stest pipeline
CentOS Stream 9 - UpstreamTests - 20CentOS-Stream-9x86_64✅ passed26.02.2026 18:26:2424min 21stest pipeline
Fedora - PyTest - 24Fedora-latestx86_64✅ passed26.02.2026 12:05:3914min 47stest pipeline
RHEL8 - UpstreamTests - 20RHEL-8.10.0-Nightlyx86_64❌ error27.02.2026 10:14:2929min 16stest pipeline
CentOS Stream 10 - PyTest - 22-minimalCentOS-Stream-10x86_64✅ passed26.02.2026 12:05:5018min 25stest pipeline
RHEL8 - UpstreamTests - 22RHEL-8.10.0-Nightlyx86_64✅ passed26.02.2026 18:26:3034min 57stest pipeline
CentOS Stream 10 - PyTest - 24CentOS-Stream-10x86_64✅ passed26.02.2026 12:34:3218min 34stest pipeline
Fedora - PyTest - 20Fedora-latestx86_64✅ passed24.02.2026 15:36:4617min 44stest pipeline
RHEL9 - UpstreamTests - 24RHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 18:26:2534min test pipeline
RHEL9 - UpstreamTests - 22RHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 18:26:2537min 8stest pipeline
CentOS Stream 9 - PyTest - 24CentOS-Stream-9x86_64✅ passed24.02.2026 15:36:3318min 20stest pipeline
Fedora - PyTest - 22-minimalFedora-latestx86_64✅ passed24.02.2026 15:43:4812min 45stest pipeline
RHEL9 - Unsubscribed host - PyTest - 20RHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 12:28:0419min 35stest pipeline
CentOS Stream 10 - PyTest - 24-minimalCentOS-Stream-10x86_64✅ passed26.02.2026 12:20:1316min 29stest pipeline
CentOS Stream 9 - PyTest - 20CentOS-Stream-9x86_64✅ passed26.02.2026 12:40:3816min 26stest pipeline
RHEL10 - UpstreamTests - 22RHEL-10-Nightlyx86_64✅ passed26.02.2026 18:36:4233min 35stest pipeline
Fedora - PyTest - 22Fedora-latestx86_64✅ passed24.02.2026 15:56:5815min 11stest pipeline
CentOS Stream 9 - PyTest - 20-minimalCentOS-Stream-9x86_64✅ passed26.02.2026 12:22:1316min 46stest pipeline
CentOS Stream 9 - PyTest - 24-minimalCentOS-Stream-9x86_64✅ passed26.02.2026 12:36:2016min 60stest pipeline
RHEL9 - PyTest - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 12:05:4626min 58stest pipeline
RHEL9 - Unsubscribed host - PyTest - 22RHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 12:26:1819min 54stest pipeline
RHEL9 - UpstreamTests - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 18:26:5420min 55stest pipeline
RHEL10 - Unsubscribed host - PyTest - 22-minimalRHEL-10-Nightlyx86_64✅ passed26.02.2026 12:05:4119min 43stest pipeline
RHEL9 - Unsubscribed host - PyTest - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 12:05:5218min 31stest pipeline
RHEL10 - PyTest - 24RHEL-10-Nightlyx86_64✅ passed26.02.2026 12:34:1925min 60stest pipeline
RHEL10 - PyTest - 22-minimalRHEL-10-Nightlyx86_64✅ passed26.02.2026 12:05:4621min 37stest pipeline
RHEL9 - Unsubscribed host - PyTest - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 12:28:1317min 47stest pipeline
RHEL8 - PyTest - 22RHEL-8.10.0-Nightlyx86_64✅ passed24.02.2026 15:32:341h 2min 49stest pipeline
RHEL10 - Unsubscribed host - PyTest - 24RHEL-10-Nightlyx86_64✅ passed24.02.2026 15:51:3444min 44stest pipeline
RHEL9 - Unsubscribed host - PyTest - 24RHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 12:34:1324min 28stest pipeline
RHEL8 - PyTest - 20RHEL-8.10.0-Nightlyx86_64✅ passed26.02.2026 12:38:4028min 33stest pipeline
RHEL10 - PyTest - 24-minimalRHEL-10-Nightlyx86_64✅ passed26.02.2026 12:42:2127min 42stest pipeline
RHEL9 - Unsubscribed host - PyTest - 20-minimalRHEL-9.6.0-Nightlyx86_64✅ passed24.02.2026 16:14:5225min 56stest pipeline
RHEL10 - Unsubscribed host - PyTest - 24-minimalRHEL-10-Nightlyx86_64✅ passed26.02.2026 12:05:3821min 23stest pipeline
RHEL8 - PyTest - 22-minimalRHEL-8.10.0-Nightlyx86_64✅ passed26.02.2026 12:28:1021min 25stest pipeline
RHEL9 - PyTest - 22RHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 12:05:4127min 2stest pipeline
RHEL9 - PyTest - 24-minimalRHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 12:05:4226min 20stest pipeline
RHEL9 - PyTest - 24RHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 12:05:5027min 15stest pipeline
Fedora - PyTest - 24-minimalFedora-latestx86_64✅ passed26.02.2026 12:05:4112min 32stest pipeline
CentOS Stream 10 - PyTest - 22CentOS-Stream-10x86_64✅ passed24.02.2026 16:31:2417min 23stest pipeline
RHEL9 - PyTest - 22-minimalRHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 12:05:4626min 49stest pipeline
RHEL10 - PyTest - 22RHEL-10-Nightlyx86_64✅ passed26.02.2026 12:05:4621min 39stest pipeline
RHEL10 - Unsubscribed host - PyTest - 22RHEL-10-Nightlyx86_64✅ passed26.02.2026 12:39:3128min 40stest pipeline
RHEL8 - PyTest - 20-minimalRHEL-8.10.0-Nightlyx86_64✅ passed26.02.2026 12:31:3124min 23stest pipeline
RHEL9 - PyTest - 20RHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 12:05:4728min 21stest pipeline
Fedora - UpstreamTests - 22-minimalFedora-latestx86_64✅ passed25.02.2026 12:52:325min 12stest pipeline
RHEL9 - UpstreamTests - 20RHEL-9.6.0-Nightlyx86_64✅ passed26.02.2026 18:26:2334min 33stest pipeline

@phracek
Copy link
Member Author

phracek commented Feb 24, 2026

The pino failing test:

✔ esm support (9.184838ms)
✔ named exports support (1.552163ms)
✔ destination (106.303493ms)
ℹ tests 528
ℹ suites 9
ℹ pass 527
ℹ fail 0
ℹ cancelled 1
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 97047.593303

✖ failing tests:

test at test/transport/big.test.js:1:1
✖ /opt/app-root/src/test/transport/big.test.js (60036.423573ms)
  'test timed out after 60000ms'

@pacostas Can you please analyze it, so I can fix it? Thanks

@pacostas
Copy link
Contributor

pacostas commented Feb 24, 2026

It seems that the CI env variable is not visible from the test as the error still exists.

test at test/transport/big.test.js:20:1
✖ eight million lines (57342.333022ms)
  Error: Command was killed with SIGABRT (Aborted): /usr/bin/node-24 /opt/app-root/src/test/fixtures/transport-many-lines.js /tmp/pino-829-cd6e97de255aad498247b461

@phracek
Copy link
Member Author

phracek commented Feb 25, 2026

Let's try one more shot after ce4a79e

[test-upstream]

@phracek
Let's deliver variable CI=true into container alone.
3ad1051 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Feb 25, 2026

@pacostas It looks like all is solved except Fedora, can you please take a look at logs and analyze it? Thankx

@phracek
Fedora 38 and 40 reached EOL
0f8e05d 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Feb 26, 2026

[test-upstream]

@phracek
Update README.md file
f94ddfe 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Feb 26, 2026

[test-pytest]

@phracek
Copy link
Member Author

phracek commented Feb 26, 2026

@pacostas Only RHEL8 is failing. Look at the logs.

 [FAILED] for 'binary' test_run_binary_application (00:01:55)

It looks like rdkafka error:

npm error gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
npm error /bin/sh: cmp: command not found
npm error /bin/sh: line 3: cmp: command not found
npm error g++: error: unrecognized command line option '-std=c++20'; did you mean '-std=c++2a'?
npm error make: *** [node-librdkafka.target.mk:123: Release/obj.target/node-librdkafka/src/binding.o] Error 1
npm error gyp ERR! build error 
npm error gyp ERR! stack Error: `make` failed with exit code: 2
npm error gyp ERR! stack at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:209:23)
npm error gyp ERR! System Linux 4.18.0-553.107.1.el8_10.x86_64
npm error gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm error gyp ERR! cwd /opt/app-root/src/node_modules/node-rdkafka
npm error gyp ERR! node -v v20.20.0
npm error gyp ERR! node-gyp -v v10.1.0
npm error gyp ERR! not ok
npm error A complete log of this run can be found in: /opt/app-root/src/.npm/_logs/2026-02-26T12_35_30_900Z-debug-0.log
Error: building at STEP "RUN /usr/libexec/s2i/assemble": while running runtime: exit status 1
  ERROR: Failed to to build /tmp/tmp.ro0WUsSsrO/Dockerfile.SIdh
Test for image 'ubi8/nodejs-20:20' FAILED (exit code: 1)

The rest finally PASSED.

@pacostas
Copy link
Contributor

pacostas commented Feb 26, 2026

The test_binary is a little bit flaky, some times it fails on the nightly test runs. Can we re-trigger only the RHEL8 upstreamTest 20 tests?

@phracek
Copy link
Member Author

phracek commented Feb 26, 2026

[test-upstream]

@phracek
Copy link
Member Author

phracek commented Feb 27, 2026

@pacostas Still failing with the same reason.

@phracek
Copy link
Member Author

phracek commented Feb 27, 2026

Maybe I would prefer to merge this and address RHEL8 failures later on. Or disable testing it for RHEL8

@pacostas
Copy link
Contributor

pacostas commented Feb 27, 2026 •
edited
Loading

I agree, all of the tests are passing except this one. Also is also not related to the PR, plus, probably soon will be fixed, as it happens many times and on the nigtly tests, the binary_test to fail for a few days and after that becoming green.

I think is good to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phracek @pacostas