Handle GString compiler args in Gradle plugin#968
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #801
Groovy build scripts that append interpolated strings to compiler args (
options.compilerArgs << "${...}") putGStringImplobjects into the list. The plugin's duplicate-checkargs.stream().anyMatch(arg -> arg.startsWith("-Xplugin:scip"))on aList<String>inserts an erasure-driven checked cast toStringper element, throwing:The fix iterates
compilerArgsthrough aList<?>reference and compares viaString.valueOf(arg), so no element is ever cast toString. (Casting inside the lambda body would not help: the erasedPredicate.test(Object)bridge casts the argument before the body runs.)Includes a regression fixture (
gradle/gstring-compiler-args) that appends a GString tocompilerArgs; without the fix it fails with the exact error from the issue, with the fix allGradleBuildToolTesttests pass.