added droplet example#59
Open
jrmlhermitte wants to merge 2 commits intoscikit-beam:masterfrom
jrmlhermitte:droplet
Open
added droplet example#59jrmlhermitte wants to merge 2 commits intoscikit-beam:masterfrom jrmlhermitte:droplet
jrmlhermitte wants to merge 2 commits intoscikit-beam:masterfrom
jrmlhermitte:droplet
Conversation
Member
|
Very cool. Thanks for this notebook! Might I suggest a name change on the functions in from skbeam.core.accumulators.droplet import dropletfind, dropletanalwe have the word from skbeam.core.accumulators import dropletand then do droplet.find(...)
droplet.analyze(...)this has the advantage of also getting rid of the, uh (this is awkward) unintentionally suggestive All of this is of course if we decide to keep the droplet algorithm, so let's let that discussion run its course before any changes are made here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added ipython notebook demonstrating use of droplet algorithm