Enrich access to evaluator's variables

[JaredDavis22]

Small change to allow discovery of variable names.

[ctrueden]

@JaredDavis22 How would you feel about a new method:

public Map<String, Object> getVars() {
	return Collections.unmodifiableMap(vars);
}

You could then of course call .keySet() on the method's returned object to get the variable names. Or just iterate the entries directly. I'd like to avoid callers overwriting variables by direct map manipulation, because an alternative Evaluator implementation might rely on callers going through the set methods, for example. But at the same time, it's convenient to access an object representing the entire map, rather than only the key set.

[ctrueden]

As usual, I'm just waffling on naming. Do you like getAll() (for symmetry with setAll) or getVars more?

[JaredDavis22]

getVars() approach works for me as well. Did the getNames approach allow for direct manipulation of the map? Was the direct manipulation comment justification for the Collections.modifiableMap wrapper?

getAll() seems better.

Is there a way to clear the map? setAll adds to existing map.

getAll() and clear() ?

[ctrueden]

Yeah, the direct manipulation comment was about returning a read-only map wrapper. I agree that getNames would not have allowed direct manipulation either—but you'd need to iterate over the keys and call get on each one to get all the values; a getAll with the map view itself seems more flexible here.

A clear() function totally makes sense. Do you think we need remove(String) as well? We probably shouldn't go overboard on implementing the entire Map interface contract... 😆

[JaredDavis22]

adding remove does make sense. Let me add that.

What about testing/test cases?

[ctrueden]

I just whipped up some tests for get/set/getAll/setAll. Let me know when you're done on your side, and I can add them in.

[JaredDavis22]

All set now

[ctrueden]

@JaredDavis22 Thank you for contributing! I've released parsington 3.2.0 to Maven Central with these improvements. 🍻

[JaredDavis22]

Wow - that was fast. Thanks for the great project!