Skip to content

Write meshtags on input mesh#50

Open
jorgensd wants to merge 1 commit into
mainfrom
dokken/write_mestags_on_input_mesh
Open

Write meshtags on input mesh#50
jorgensd wants to merge 1 commit into
mainfrom
dokken/write_mestags_on_input_mesh

Conversation

@jorgensd
Copy link
Copy Markdown
Member

(Looking at you @finsberg and @MariusCausemann) we can now write meshtags on input mesh.

@jorgensd jorgensd requested a review from finsberg May 19, 2026 08:25
@jorgensd jorgensd added the enhancement New feature or request label May 19, 2026
Copy link
Copy Markdown
Member

@finsberg finsberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @jorgensd! This is definitely the source of many bugs that I have encountered, and I am wonder whether it would make sense to make the default behaviour to use the input mesh (also for function)? I know that it will not be as performant, but IMO it is better to avoid bugs, than being a bit more performant 🙃

@jorgensd
Copy link
Copy Markdown
Member Author

This is great @jorgensd! This is definitely the source of many bugs that I have encountered, and I am wonder whether it would make sense to make the default behaviour to use the input mesh (also for function)? I know that it will not be as performant, but IMO it is better to avoid bugs, than being a bit more performant 🙃

I refuse to change the default behaviour of the functions;

  1. Changing defaults should have a very good reason
  2. Degrading performance when the documentation clearly states what kind of checkpoints exists makes it kind of pointless to have documentation.
  3. Now that we have write_point_data and write_cell_data, I think most use-cases for people will be reading in data from visualizable files rather than checkpointing files.

@finsberg finsberg self-requested a review May 19, 2026 11:48
Copy link
Copy Markdown
Member

@finsberg finsberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment, otherwise feel free to merge.

Comment on lines +684 to +686
if is_complex:
values[0] -= 3j * x[1]
values[1] += 2j * x[0]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can just remove this, it is_complex always is False?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, remainder from copying old test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants