Attach adjoint LinearSolver/Nonlinearsolver objects to original solver class. - #77
Draft
jorgensd wants to merge 7 commits into
Draft
Attach adjoint LinearSolver/Nonlinearsolver objects to original solver class. #77jorgensd wants to merge 7 commits into
jorgensd wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version of the code, we associate a new SolverBlock (which includes a forward solver, adjoint solver and tlm solver) with each subsequent call to
problem.solve().This is horrible for many reasons, including:
The current implementation, which was initially based on legacy DOLFIN-adjoint did all of these things lazy, and threw away solvers at random points. With later versions of PETSc the Python garbage collector and PETSc GB can start fighting causing deadlocks.