Fix memory leaks while handling messages 6, 8 and 24#198
Open
simeonmiteff wants to merge 2 commits intoschwehr:masterfrom
Open
Fix memory leaks while handling messages 6, 8 and 24#198simeonmiteff wants to merge 2 commits intoschwehr:masterfrom
simeonmiteff wants to merge 2 commits intoschwehr:masterfrom
Conversation
fix significant memory leaks that occur when decoding fails
|
Hello, We experienced a severe memory leak as well and this patch fixed the issue, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix rather rapid memory leaks caused by Python objects allocated in the handling of messages 6, 8 and 24 not being freed because of missing Py_DECREF calls when encountering an error and returning nullptr.