Repository navigation
Fix Windows Jump destination parity - #967
Merged
Merged
Conversation
Reuse the production activation path, preserve stale destinations, and apply the macOS blocked-loop admission rule with retained presence exit status. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Add headless destination controls to the shared shell and compiled functional adapter. Keep native/runtime qualification explicitly pending. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Reuse the existing shell scope and capture pump for live create-new logs, preserve shared cleanup budgets and UNKNOWN retention, and exercise actual dispatch with owned non-GUI children. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Use the existing owned-child supervisor for discovery and compile/test under one clock, preserve raw streams and unknown leases, and verify 16 headless safety controls without executing a C++ fixture. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Share the EN_CHANGE query reader with the gated refresh message instead of forcing the UIA loop B fixture. Cover A/B/cross-project, empty and unmatched queries plus Return destination behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Reuse the existing WM_SETTEXT helper, preserve the destination oracle, and register headless and bounded owned cross-process regressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Windows Jump destination parity so selecting a result activates the same leaf-loop destination as sidebar navigation, and ensure palette refresh reads the actual edit buffer.
Closes #799.
Changes
WM_SETTEXTpath in acceptance coverage.Test plan
RED: & $env:GRAPHCODE_ZIG0152 test src\JumpPalette.zig -target x86_64-windows-msvc -lc -luser32 -lgdi32 --test-filter "jump query refresh follows the actual search buffer and preserves the selected destination" -> expected loop-a, found loop-b
GREEN: & $env:GRAPHCODE_ZIG0152 test src\JumpPalette.zig -target x86_64-windows-msvc -lc -luser32 -lgdi32 --test-filter "jump query refresh follows the actual search buffer and preserves the selected destination" -> 1/1 passed
REGRESSION: pwsh -NoLogo -NoProfile -File .\Tools\windows\validate.ps1 -Task windows-shell -SkipTrayLive -ShellValidationRoot D:\a79 -ShellTestManifest D:\a79\current-ed2f4ee6-retry04\manifests\all.json -SwiftExecutable C:\Users\coneilen\AppData\Local\Programs\Swift\Toolchains\6.3.3+Asserts\usr\bin\swift.exe -> exit 0; 66/66 shell sections
make testandmake checkwere not run because the change is Windows-only.Checklist
git commit -s) per the DCOmake test)make check)