WKBCH-26: Launch vault via node instead of yarn start#80
Merged
Conversation
Vault 7.89.0 ships an .npmrc referencing ${NODE_AUTH_TOKEN} for build-time
package authentication. Invoking yarn at container start makes yarn read
that file and abort with 'Failed to replace env in config: ${NODE_AUTH_TOKEN}'
because the variable is unset at runtime.
Match the production Vault and MetaData pattern by launching the node entry
point directly. This is what 'yarn start' resolves to (see Vault's package.json)
and avoids reading the .npmrc altogether.
|
LGTM — clean, focused fix. The direct Review by Claude Code |
anurag4DSB
approved these changes
May 15, 2026
BourgoisMickael
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.npmrcreferencing${NODE_AUTH_TOKEN}(used only at build time via secret mount). Runningyarn startat container startup makes yarn read that file and abort withFailed to replace env in config: ${NODE_AUTH_TOKEN}since the variable is unset at runtime.node bin/...) both bypass yarn at runtime. This change aligns the workbench vault command with that pattern by invokingnode --max-http-header-size=32768 vaultd.jsdirectly - this is whatyarn startresolves to Vault'spackage.json: https://github.com/scality/Vault/blob/819c4992a5d08ab2bb0355654bdd7e222eae16a4/package.json#L59