Dual-publish to npm and GitHub Packages on release#27
Draft
delthas wants to merge 1 commit into
Draft
Conversation
Add a publish-github job to the release workflow that reuses the build artifact and publishes @scality/cloudserverclient to GitHub Packages via GITHUB_TOKEN, in parallel with the existing npm publish. Remove the publishConfig.registry pin to npmjs so each publish job's setup-node controls its target registry, and gate the GitHub release on both publishes succeeding. Issue: CLDSRVCLT-16 Claude-Session: https://claude.ai/code/session_01C3bvjpTmCfPRxqsCRiFXb7
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds GitHub Packages as a second publish target on release, so
@scality/cloudserverclientis dual-published to both npmjs and GitHub Packages — matching@scality/hdclient. Today only a stale1.0.0sits on GitHub Packages.Changes
publish-githubjob in.github/workflows/release.yml: reuses thebuild-artifacts(checkout + download-artifact), sets up Node againstnpm.pkg.github.com, and runs a plainnpm publishwithNODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}(packages: write). Runs in parallel with the existing npm publish, off the same build.publishConfig.registrypin to npmjs inpackage.json(keptaccess: public). The pin would otherwise force the GH Packages job to publish to npmjs; now each job'ssetup-nodecontrols its target registry (mirrors hdclient).create-releasenowneedsboth publishes, so the GitHub release only fires once both registries have the version.Why
Step toward migrating Scality Node consumers (cloudserver, backbeat, s3utils, Zenko) to pull
@scality/*from GitHub Packages (ARSN-605). The@scality:registryredirect applies to the whole scope, so every@scality/*dependency must be available on GitHub Packages; cloudserverclient is the main gap.Notes
package.json; npm publish keeps--provenance+ OIDC trusted publishing. GH Packages uses a plain publish (no provenance).E409 cannot publish over existing versionand needs manual reconciliation.Issue: CLDSRVCLT-16
https://claude.ai/code/session_01C3bvjpTmCfPRxqsCRiFXb7