Skip to content

Dual-publish to npm and GitHub Packages on release#27

Draft
delthas wants to merge 1 commit into
development/1.0from
improvement/CLDSRVCLT-16/dual-publish-github-packages
Draft

Dual-publish to npm and GitHub Packages on release#27
delthas wants to merge 1 commit into
development/1.0from
improvement/CLDSRVCLT-16/dual-publish-github-packages

Conversation

@delthas

@delthas delthas commented Jul 2, 2026

Copy link
Copy Markdown

What

Adds GitHub Packages as a second publish target on release, so @scality/cloudserverclient is dual-published to both npmjs and GitHub Packages — matching @scality/hdclient. Today only a stale 1.0.0 sits on GitHub Packages.

Changes

  • publish-github job in .github/workflows/release.yml: reuses the build-artifacts (checkout + download-artifact), sets up Node against npm.pkg.github.com, and runs a plain npm publish with NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} (packages: write). Runs in parallel with the existing npm publish, off the same build.
  • Removed the publishConfig.registry pin to npmjs in package.json (kept access: public). The pin would otherwise force the GH Packages job to publish to npmjs; now each job's setup-node controls its target registry (mirrors hdclient).
  • create-release now needs both publishes, so the GitHub release only fires once both registries have the version.

Why

Step toward migrating Scality Node consumers (cloudserver, backbeat, s3utils, Zenko) to pull @scality/* from GitHub Packages (ARSN-605). The @scality:registry redirect applies to the whole scope, so every @scality/* dependency must be available on GitHub Packages; cloudserverclient is the main gap.

Notes

  • Keeps the existing release model: version comes from committed package.json; npm publish keeps --provenance + OIDC trusted publishing. GH Packages uses a plain publish (no provenance).
  • Dual-publish is not atomic: if one registry succeeds and the other fails, a re-run hits E409 cannot publish over existing version and needs manual reconciliation.

Issue: CLDSRVCLT-16

https://claude.ai/code/session_01C3bvjpTmCfPRxqsCRiFXb7

Add a publish-github job to the release workflow that reuses the build
artifact and publishes @scality/cloudserverclient to GitHub Packages via
GITHUB_TOKEN, in parallel with the existing npm publish. Remove the
publishConfig.registry pin to npmjs so each publish job's setup-node
controls its target registry, and gate the GitHub release on both
publishes succeeding.

Issue: CLDSRVCLT-16
Claude-Session: https://claude.ai/code/session_01C3bvjpTmCfPRxqsCRiFXb7
@bert-e

bert-e commented Jul 2, 2026

Copy link
Copy Markdown

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jul 2, 2026

Copy link
Copy Markdown

Incorrect fix version

The Fix Version/s in issue CLDSRVCLT-16 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.0.10

Please check the Fix Version/s of CLDSRVCLT-16, or the target
branch of this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants