Skip to content

Extend GetObjectAttributes and ListObjectsV2 with user metadata support#13

Open
maeldonn wants to merge 5 commits intodevelopment/1.0from
improvement/CLDSRVCLT-10/user-metadata
Open

Extend GetObjectAttributes and ListObjectsV2 with user metadata support#13
maeldonn wants to merge 5 commits intodevelopment/1.0from
improvement/CLDSRVCLT-10/user-metadata

Conversation

@maeldonn
Copy link

Issue: CLDSRVCLT-10

@maeldonn maeldonn requested review from a team, SylvainSenechal and delthas March 11, 2026 18:03
@bert-e
Copy link

bert-e commented Mar 11, 2026

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@maeldonn maeldonn force-pushed the improvement/CLDSRVCLT-10/user-metadata branch from e05ea19 to e123b2d Compare March 11, 2026 18:12
@maeldonn maeldonn force-pushed the improvement/CLDSRVCLT-10/user-metadata branch from e123b2d to f1b000f Compare March 12, 2026 10:49
@scality scality deleted a comment from bert-e Mar 12, 2026
@bert-e
Copy link

bert-e commented Mar 12, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@maeldonn maeldonn force-pushed the improvement/CLDSRVCLT-10/user-metadata branch from 7f8564d to 5eaa299 Compare March 12, 2026 18:23

import { S3Client, S3ClientConfig } from '@aws-sdk/client-s3';
import { ListObjectsV2ExtendedCommand } from '@scality/cloudserverclient/clients/s3Extended';
import { ListObjectsV2ExtendedCommand } from '@scality/cloudserverclient/commands/s3Extended';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised I can't import ListObjectsV2ExtendedCommand in my code editor.
I have to add /index after /s3extended to be able to import it.
I see in Zenko you directly imported with @scality/cloudserverclient

Anyways, you can update this example import if it's broken, or tell me if its because I misconfigured something on my code editor ?

parseUserMetadataMiddleware,
} from './utils';

export interface GetObjectAttributesExtendedInput extends Omit<GetObjectAttributesCommandInput, 'ObjectAttributes'> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn i really dont know enough about typescript 😆

Copy link
Contributor

@SylvainSenechal SylvainSenechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just double check the small s3extended command example file import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants