Do not delete data on a CRR location when backbeat updates metadata

[SylvainSenechal]

Issue: CLDSRV-1034

When backbeat updates an object's metadata with the cloudserver’s backbeat api, cloudserver deletes the object's old data locations if they changed.

With pull replication, the sink copies an object's data from a remote CRR location (the source site) to a local one, then updates the metadata. The old location is then the object on the source site, and cloudserver tries to delete it. Today the delete only fails by luck: cloudserver has no data client for CRR locations, so the delete throws an error, and backbeat gets an error for a metadata write that actually succeeded.

Data on a CRR location belongs to another site.

Backbeat already refuses to delete it (added recently with the pull replication Epic), in the lifecycle transition processor and in the GC (locationsConfig[dataStoreName]?.isCRR).

[bert-e]

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/bypass_source_branch_lineage	Bypass the cross-branch contamination check	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request.
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.82%. Comparing base (e7ee82d) to head (59c71a8).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/routes/routeBackbeat.js	78.86% <ø> (ø)

... and 3 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.5    #6328      +/-   ##
===================================================
- Coverage            87.89%   87.82%   -0.08%     
===================================================
  Files                  206      206              
  Lines                14193    14193              
===================================================
- Hits                 12475    12465      -10     
- Misses                1718     1728      +10     

Flag	Coverage Δ
checksums-disabled-tests	35.66% <ø> (ø)
file-ft-tests	71.27% <ø> (-0.03%)	⬇️
file-ft-tests-null-compat	71.81% <ø> (+0.02%)	⬆️
kmip-ft-tests	28.23% <ø> (ø)
mongo-v0-ft-tests	72.54% <ø> (-0.08%)	⬇️
mongo-v1-ft-tests	72.52% <ø> (-0.02%)	⬇️
multiple-backend	36.45% <ø> (ø)
s3c-ft-tests-v0	66.36% <ø> (-0.02%)	⬇️
s3c-ft-tests-v0-null-compat	66.43% <ø> (ø)
s3c-ft-tests-v1	66.34% <ø> (-0.02%)	⬇️
sur-tests	36.99% <ø> (-0.03%)	⬇️
sur-tests-inflights	39.89% <ø> (-0.03%)	⬇️
unit	75.41% <ø> (ø)
utapi-v2-tests	35.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[SylvainSenechal]

This is pretty much https://github.com/scality/backbeat/blob/85aaab3c7ecfbbb8dcdebca21e8895f16634c9f6/extensions/lifecycle/tasks/LifecycleUpdateTransitionTask.js#L121