-
Notifications
You must be signed in to change notification settings - Fork 3
Add gemini example using litellm #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
7f354a5 to
84e453c
Compare
| debugpy.configure(subProcess=False) | ||
| debugpy.listen(debug_port) | ||
|
|
||
| print(f"[{debug_type.upper()}] Debug server listening on port {debug_port}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe worth getting rid of some of these print statements for the sake of this being a tutorial?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call
84e453c to
b01897a
Compare
| # We are also adding the Open AI Agents SDK plugin to the ACP with LiteLLM provider. | ||
| type="temporal", | ||
| temporal_address=os.getenv("TEMPORAL_ADDRESS", "localhost:7233"), | ||
| plugins=[OpenAIAgentsPlugin( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is because the plugin works with temporal right whereas there isn't a "google" version? not anything else? if so, may be worth to mention that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
umm, kind of i mean there is google adk, but this is just showing how to use a different model provider with the OAI agents plugin (since temporal has already created it) not the only way of doing it but a nice way to do it since you dont have to deal with serialization and all that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a little more detail in that comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah no that makes sense! I guess what I meant is that there is no other temporal <> google plugin integration i guess that can we use out of the box without having to make it ourselves
b01897a to
b9711fd
Compare
cceb5a2 to
03e8d58
Compare
03e8d58 to
74b9560
Compare
Add gemini example using litellm