Repository navigation
fix(computer): keep OneDrive's per-user setup out of the Windows base - #586
Merged
earakely-scale merged 1 commit intoNov 10, 2026
Merged
Conversation
OneDrive set itself up at the session user's first sign-in, from the default profile's Run key, and left two RunOnce deletes behind. Each is a console command, which Windows 11 opens in a Terminal window that takes the foreground for about 350 ms; a composed disk boots afresh every time, so they ran at every boot and took keys typed through SendInput (agent-desktop's WindowsDriver), failing the probe's P6 typing checks now and then. The base now removes OneDriveSetup from the default profile's Run key before the session user's profile exists. Part of FD-5418. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
deleted the
edgararakelyan/fd-5418-windows-base-without-onedrive
branch
November 10, 2026 02:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of FD-5418. This follows #583, which merged before the fix was pushed.
On a Windows desk, the probe's P6 typing checks failed now and then with agent-desktop (2 of 8 probes): 3 to 5 typed keys didn't arrive.
The cause is in the Windows base, not the driver.
RunOnceentries behind, each acmd.exe /q /c del ….SendInputduring that window went to Terminal, not the app.A watcher inside the guest found the cause. It logged foreground windows and new processes during the probe:
explorer.exestarted the twocmd.exeat logon, their Terminal windows took the foreground, and the session user'sRunOnceheld the two OneDrive entries.What changes
setup.ps1removesOneDriveSetupfrom the default profile's Run key, beside the other default-profile settings, before the session user's profile exists. OneDrive never sets itself up for that user. TheRunOnceentries, the background OneDrive process and the Terminal windows are gone.What it costs: the base setup changes, so each machine with a Windows base installs a fresh one once (about 15 minutes), and its Windows desks recompose.
Tests
On an agent-environments-admin box, I installed a fresh base from Microsoft's ISO and composed a
windows-11desk withdriver = "agent-desktop":cmd.exe, Terminal window or OneDrive process started in any round.RunOnce.🤖 Generated with Claude Code


Confidence Score: 5/5
This PR appears safe to merge.Summary
Removes startup commands containing
OneDriveSetupfrom the default Windows profile before the session user's first sign-in.Reviews (1) · Last reviewed commit: "fix(computer): keep OneDrive's per-user ..." · Reviewed by Greptile