Skip to content

test: have the local stack remove only the sandboxes its own process made #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewpark-scaleai merged 1 commit into from
Nov 10, 2026
Merged

test: have the local stack remove only the sandboxes its own process made #584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions tst/integration/store/local_parallel_deploy_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from agent_env.store.image_store import LocalRegistryImageStore
from agent_env.task import Task
from agent_env.task.store import get_task_instance_store
from agent_env.providers.sandbox_providers.local_docker.provider import LocalSandbox
from agent_env.task_step.task_steps.deploy_env import DeployEnvTaskStep
from tst.integration.utils.registry import REGISTRY_IMAGE
from tst.task import journal_invariants as journal
Expand Down Expand Up @@ -80,6 +81,15 @@ def local_stack_at(monkeypatch: pytest.MonkeyPatch, path: Path):
_docker("rm", "-f", reg_name)
pytest.skip("local registry did not become ready")

# The sandboxes this process makes while the stack is up, whose containers alone it removes: another process's,
# as another pytest worker's, share this machine's Docker and its names.
made, init = [], LocalSandbox.__init__

def recorded(self, *args, **kwargs):
init(self, *args, **kwargs)
made.append(self.sandbox_id)

monkeypatch.setattr(LocalSandbox, "__init__", recorded)
monkeypatch.chdir(path)
for var in ("DOCUMENT", "OBJECT", "IMAGE"):
monkeypatch.setenv(f"AGENT_ENV_{var}_STORE", "local")
Expand All @@ -89,8 +99,9 @@ def local_stack_at(monkeypatch: pytest.MonkeyPatch, path: Path):
try:
yield host
finally:
for cid in _docker("ps", "-aq", "--filter", "name=agent-env-local-").stdout.split():
_docker("rm", "-f", cid)
for sandbox_id in set(made):
for cid in _docker("ps", "-aq", "--filter", f"name=agent-env-{sandbox_id}-").stdout.split():
_docker("rm", "-f", cid)
reset_artifact_store()
reset_config()
_docker("rm", "-f", reg_name)
Expand Down
Loading