Repository navigation
fix(#3095): concept/topic/channel page layout — container padding + cap relationship walls - #3106
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3095.
Problem
Concept detail pages (and, with the same root cause,
/topics/*,/channels/*, and the/channels/index) render flush against the left browser edge — content has no outer padding, making it hard to read. CAP serves these bodies into the shell's bare<main>with no shared container, so each body's root class must supply its own width/padding — four of them never did.Separately, concept hub pages dump the entire relationship list:
sap-btp-fundamentalsrenders 235 "Concepts that build on this" tiles with no cap — the likely source of the reporter's "looks not like it is 100% ready" remark.Fix
sap-fundamental.src.css(the git-tracked source — the minified.cssis a gitignored build output) gives.concept-page,.topic-detail,.channel-detail,.channels-pagethe site-standardmax-width:1280px; margin:0 auto; padding:1.5rem 2rem 3rem(matching.group-body/.mission-body), plus the matching mobile@mediapadding:1removerride for sibling parity.renderCappedGridhelper caps the four KG-relationship sections (teaches / requires / requiredBy / relatedTo) at 24 visible tiles; overflow moves into a no-JS<details>collapse ("Show all N"). Corpus sampling confirmed onlyrequiredByballoons; external/phase-4 sections (naturally small) are left uncapped.rebuild-content.yml) after deploy to reach served HANA BLOBs.Tests
test/concept-page-container.test.js— source-string guard for the grouped rule (desktop + mobile) and that the index classes aren't folded in.test/concept-detail-cap.test.js— N-boundary (24/25/235), escaping in the collapsed half, phase-4 untouched.Post-deploy verification (to confirm on DEV)
curl
/concepts/sap-btp-fundamentals/,/concepts/cap-golden-path-best-practices/, a/topics/<slug>/,/channels/, and a/channels/<slug>/: confirm container padding on all, and that the hub page shows 24 tiles + a "Show all 235"<details>.Design:
docs/superpowers/specs/2026-11-11-concept-page-layout-design.md· Plan:docs/superpowers/plans/2026-11-11-concept-page-layout.md