Repository navigation
Release 1.44.0: DEV to main promotion - #3089
Merged
Merged
Conversation
…n,n] fences (#3076) Restore the AEM-era line-highlight convention authors used, e.g.: ```HTTP[4, 9, 12, 15] Rendered as a SAP-blue attention band (Horizon light + dark) over the named lines — purely additive, non-highlighted lines untouched. - scripts/parsers/code-highlight-lines.ts: new fence-aware pass rewriting the legacy `LANG[4, 9, 12]` info string to Hugo's native `LANG {hl_lines="4 9 12"}` attribute (ranges supported; brackets inside code content / nested fences / already-attributed fences untouched). - compose.ts: wire the rewrite in after the blockquote-fence heal so it reaches both step parsing and intro extraction. - render-codeblock.html: read hl_lines/linenos from .Options (where Goldmark actually routes highlighting options) with .Attributes fallback — previously only .Attributes was read, so hl_lines silently never rendered. - sap-fundamental.src.css: style .code-block-body .chroma .hl as the band. - Tests: 13 parser unit cases + source/compiled CSS guard. Known gaps (documented in the parser): CDS blocks (Shiki post-build) and blockquoted code fences do not carry the band.
…ght-3076 feat(code): highlight specific lines in code samples (#3076)
Version bump 1.43.0 → 1.44.0 in .deploy/mta.yaml (the deploy source of truth) and a What's New refresh covering 41 merged PRs since the 1.43.0 release. Highlights shipping in 1.44.0: - Interactive tutorial rich media now works on every tutorial page — the terminal-recording (asciinema) player, before/after image compare slider, and click-to-highlight code walkthroughs (#3085, superseding #3081). - Code samples can highlight specific lines with a colored attention band (#3084). - Dead tutorial cross-references now fail the content build loudly (#3082). - Reusable content snippets expand correctly in CI builds (#3078). - Filterable developer-advocates OData collection (#3077). - Numerous directive-rendering fixes (menu breadcrumbs, callouts, walkthroughs, content includes) that eliminate raw markup leaking onto published pages.
release 1.44.0 prep: version bump + whats-new refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.44.0 — DEV → main promotion
Promotes DEV to main for the 1.44.0 PROD release. DEV is ahead of main by:
LANG[n,n]fencesMerge instruction
Merge commit (NOT squash) per
docs/developers/operations/branching-strategy.md§Release — keeps DEV an ancestor of main.REQUIRED post-merge sequence (deploy-before-rebuild)
The rich-media/walkthrough fix references three JS bundles (
cast.js,compare.js,code-walkthrough.js) that the PROD approuter does not yet serve (all 404 on PROD today). A content rebuild alone will FAIL its asset guard (it did — that's what sent us down the deploy path). The correct order:origin/main— ships the 3 bundles into approuter static (cp hugo/public/. static/). Verified on DEV: bundles now serve 200.rebuild-content.yml -f environment=prod -f mode=full) — bakes the<script>refs into published HTML. Verified on DEV: rebuild passes the asset guard, both demos reference all 3 scripts.Both steps need explicit authorization; neither is triggered by merging this PR.
Verified on DEV (end-to-end)
/js/{cast,compare,code-walkthrough}.jsserve HTTP 200 on DEV approuterdirective-code-blocks+directive-rich-mediaHTML reference all 3 scripts