feat: Update futures algo order API with new TP/SL parameters#1672
Open
paul-lestyo wants to merge 1 commit intosammchardy:masterfrom
Open
feat: Update futures algo order API with new TP/SL parameters#1672paul-lestyo wants to merge 1 commit intosammchardy:masterfrom
paul-lestyo wants to merge 1 commit intosammchardy:masterfrom
Conversation
- Enhanced futures_create_algo_order() to support new API parameters: * priceMatch: for LIMIT/STOP/TAKE_PROFIT orders (OPPONENT/QUEUE options) * priceProtect: price protection for STOP_MARKET/TAKE_PROFIT_MARKET * activatePrice & callbackRate: for TRAILING_STOP_MARKET orders * selfTradePreventionMode: STP modes (EXPIRE_TAKER/MAKER/BOTH) * goodTillDate: for GTD time in force * newOrderRespType: ACK or RESULT response type * workingType: trigger based on MARK_PRICE or CONTRACT_PRICE * closePosition: close all positions * reduceOnly: reduce only mode * timeInForce: IOC/GTC/FOK/GTX support * positionSide: LONG/SHORT for hedge mode - Updated comprehensive documentation with all parameter descriptions - Added practical code example in docstring - Created 12 new test cases for both sync and async clients: * Test priceProtect parameter * Test trailing stop with activatePrice/callbackRate (skipped for testnet) * Test selfTradePreventionMode * Test priceMatch parameter * Test newOrderRespType parameter * Test workingType parameter - Added examples/futures_algo_order_examples.py with practical usage examples This update aligns with the latest Binance Futures API documentation for New Algo Order endpoint supporting advanced TP/SL functionality. Note: Some tests may fail in testnet due to timestamp sync issues, which is a known testnet limitation, not a code issue.
Collaborator
|
@paul-lestyo thanks for your contribution, we will check it shortly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the
futures_create_algo_order()method to support the latest Binance Futures API parameters for advanced Take Profit and Stop Loss functionality, aligned with the New Algo Order API documentation.Changes
Documentation Updates
New Parameters Supported
Test Coverage
Added 12 comprehensive test cases covering:
Examples
Added
examples/futures_algo_order_examples.pywith 10+ practical usage examples for all new features.API Reference
Based on official Binance API documentation:
POST /fapi/v1/algoOrderTesting
Files Changed
binance/client.py- Enhanced documentation and method implementationtests/test_client_futures.py- Added 6 new test casestests/test_async_client_futures.py- Added 6 new async test casesexamples/futures_algo_order_examples.py- New example fileTotal: 4 files changed, 553 insertions(+), 4 deletions(-)