Conversation
In this improved version, messages are centrally located in the ERROR_MESSAGES dictionary, making future changes easier. The use of the message key in the specific exceptions allows for code to be less redundant and more unified in its structure.
realFranco
reviewed
Dec 3, 2023
Comment on lines
+4
to
+12
| ERROR_MESSAGES = { | ||
| "invalid_json": "Invalid JSON error message from Binance: {}", | ||
| "unknown_symbol": "Unknown symbol {}", | ||
| "inactive_symbol": "Attempting to trade an inactive symbol {}", | ||
| "min_amount": "Amount must be a multiple of {}", | ||
| "min_price": "Price must be at least {}", | ||
| "min_total": "Total must be at least {}", | ||
| "not_implemented": "Not implemented: {}" | ||
| } |
There was a problem hiding this comment.
Hello, seems to me that you "could" decouple this. Comes to my mind that can create a "constant" file and specify in there all the constants (including those error messages) required by this service.
If you are not happy with this you are free to solve my comment / review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this improved version, messages are centrally located in the ERROR_MESSAGES dictionary, making future changes easier. The use of the message key in the specific exceptions allows for code to be less redundant and more unified in its structure.