Conversation
|
Hi @s2t2 I do like this option to update the output, dataframes would be useful for some use cases. I don't want to have pandas as a default requirement and increase the library size. Could we make pandas an optional import or move the convertors to utility functions that can convert the output of any kline function. Then if someone wants to use it they can install pandas separately, or with a pip install python-binance[pandas] option. Open to suggestions. |
|
Hi @sammchardy thanks for your review! The optional dependency Then we'll need to leave the underlying functions untouched and add separate decorator functions. Or maybe a higher-level service-style class. I'd be happy to work on incorporating these changes. |
|
@sammchardy FYI I have implemented these changes in #1147 closing this PR in favor of that one. |

Implements an
output_formatparmater for theClient.get_historical_klinesfunction:output_format="df", returns apandas.DataFrameoutput_format="decorated", returns a list of decorated value objects.