Repository navigation
feat: run in Linux containers - #4
Merged
Merged
Conversation
As root on Linux, the headless Chrome step now runs Chrome as the nobody user with its sandbox on, instead of skipping. Chrome discovery also finds Playwright's Chromium, which many Linux images ship instead of Chrome. use_proxy (REFETCH_USE_PROXY) sends connections through HTTPS_PROXY as CONNECT tunnels inside the public-only dialer, so TLS still runs end to end. A name the proxy resolves is checked when it resolves locally. doctor reports the proxy on a new network line, and no longer suggests /reload-plugins for a development checkout run through REFETCH_BIN. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 89.51% 89.70% +0.19%
==========================================
Files 17 18 +1
Lines 1478 1652 +174
==========================================
+ Hits 1323 1482 +159
- Misses 155 169 +14
- Partials 0 1 +1
🚀 New features to boost your workflow:
|
…Chromium's owner Behind use_proxy, a name whose last label starts with a digit (0x7f.1, 2130706433) is refused instead of being left to the proxy, which may read it as an address. A Playwright Chromium found by searching runs only if it and the folders above it belong to root or this user and nobody else can write to them; as root, the --version check also runs as nobody. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ainer blocks Chrome's sandbox The profile walk goes through os.Root (gosec G122 fails CI's Linux lint). Chrome as nobody no longer keeps root's supplementary groups. As root, a Chrome that nobody cannot reach (in /root/.cache, say) is not picked. When the container blocks the user namespaces Chrome's sandbox needs, the step says so instead of "signal: aborted". codecov.yml holds the project to 85%, the cover-check line, and a change to 70% of its own lines. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
runAsNobody is split into nobody() and runAs(), so a test can hand a profile to its own user without root. New tests cover nobodyCanRun, a proxy that hangs up, is unreachable, has no port or sends bytes with its reply, and an unparsable HTTPS_PROXY. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ers can write to it Playwright's Docker images make /ms-playwright writable by everyone, so refetch does not run that Chromium on its own. doctor now names it and the REFETCH_CHROME setting that uses it anyway. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
nobodywith its sandbox on. Before, it was skipped. Other systems still skip it as root.PLAYWRIGHT_BROWSERS_PATH,/ms-playwright,/opt/pw-browsersand~/.cache/ms-playwright, newest build first.use_proxy(REFETCH_USE_PROXY, off by default): connections go throughHTTPS_PROXYas CONNECT tunnels inside the public-only dialer, except to hostsNO_PROXYlists. Literal IPs and names that resolve locally still get the public-only check; a name only the proxy can resolve is left to it (SECURITY.md says so).networkline, and a development checkout (plugin 0.0.0throughREFETCH_BIN) no longer gets/reload-pluginsadvice.How it was checked
make lint cover-check(88.7%) andclaude plugin validate . --strict.NO_PROXY, Playwright discovery, doctor's network and version lines.nobody(3 s). Locally: fetches direct and through a CONNECT proxy withuse_proxy, both clients and headless Chrome.🤖 Generated with Claude Code