Skip to content

refactor: Centralize app flow handling and service event dispatching #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Mudit200408 wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

refactor: Centralize app flow handling and service event dispatching #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

# Package Files #
*.jar
!gradle/wrapper/gradle-wrapper.jar
*.war
*.nar
*.ear
Expand Down
8 changes: 7 additions & 1 deletion app/src/main/java/com/sameerasw/essentials/services/AppDetectionService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class AppDetectionService : Service() {
override fun onCreate() {
super.onCreate()
isRunning = true
appFlowHandler = AppFlowHandler(this)
appFlowHandler = AppFlowHandler.getInstance(this)
createNotificationChannel()

val filter = IntentFilter().apply {
Expand Down Expand Up @@ -143,6 +143,12 @@ class AppDetectionService : Service() {
unregisterReceiver(authReceiver)
} catch (_: Exception) {
}
try {
if (::appFlowHandler.isInitialized) {
appFlowHandler.destroy()
}
} catch (_: Exception) {
}
Comment on lines +147 to +151

@sameerasw sameerasw Aug 21, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Issue 2: Singleton Lifecycle & Premature Listener Teardown (State Corruption)

  • Location: AppDetectionService.kt:147–151 & AppFlowHandler.kt:84–95
  • What happened:
    • AppFlowHandler is now a static singleton INSTANCE.
    • When AppDetectionService.onDestroy() runs, it calls appFlowHandler.destroy(), which unregisters SharedPreferences listeners, ComponentCallbacks, and the MEDIA_PLAYBACK_CHANGED broadcast receiver from the application context.
    • However, INSTANCE is never reset to null.
  • Impact: If AppDetectionService restarts or ScreenOffAccessibilityService continues using AppFlowHandler, the handler is left in a dead/unregistered state where preference changes and media events are permanently ignored until a full process kill.

super.onDestroy()
}

Expand Down
Loading