Drop nightly-stress-test.yml's own schedule and branch input on 3006.x - #70197
Open
charzl wants to merge 1 commit into
Open
Drop nightly-stress-test.yml's own schedule and branch input on 3006.x#70197charzl wants to merge 1 commit into
charzl wants to merge 1 commit into
Conversation
charzl
changed the title
charzl
added a commit
that referenced
this pull request
Aug 31, 2026
This PR's scope shrinks to just run-nightly-stress.yml's matrix change. nightly-stress-test.yml's rewrite (dispatcher-loop removal, schedule removal, SKIP_NIGHTLY_STRESS_TEST dedup) is being established on 3006.x first (#70197) and will be ported to master and 3008.x as separate, later changes -- not bundled into this PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
charzl
changed the title
charzl
changed the title
run-nightly-stress.yml (master) now dispatches every branch's nightly stress test explicitly via its matrix, so 3006.x's own schedule: was redundant -- it never actually fired anyway, since GitHub only honors schedule: from the repository's default branch. Drop it and let run-nightly-stress.yml be the sole cron entry point and sole branch list, matching the existing nightly.yml/run-nightly.yml split. Also drop the branch workflow_dispatch input: every real caller already passes --ref matching it, so github.ref_name reads the same value without a second parameter that could drift out of sync. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
charzl
force-pushed
the
feature/run-stress-test
branch
from
August 31, 2026 23:30
e4b1cdc to
9b6a3b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nightly-stress-test.yml's ownschedule:trigger on 3006.x --run-nightly-stress.yml(master) becomes the sole cron owner and sole branch list, matching the existingnightly.yml/run-nightly.ymlsplit elsewhere in this repobranchworkflow_dispatch input (previouslyrequired: true, no default); every place that readinputs.branch(checkout ref, Docker layer cache key, artifact name, stress-snapshots run path) now readsgithub.ref_nameinsteadWhy
3006.x's
schedule:never actually fires (GitHub only honorsschedule:from the repository's default branch), so it was dead weight. Meanwhile the file already relied on the caller to pass-f branch=3006.xexplicitly, which is redundant with--ref 3006.x-- both were always set to the same value by any real caller, sogithub.ref_namereads the same information without a second parameter that could drift out of sync.Test plan
python3 -c "import yaml; yaml.safe_load(open(...))")nightly-stress-test.yml --ref 3006.x(no-fflags) and confirm the job runs end-to-end against 3006.xhttps://github.com/charzl/salt/actions/runs/33450150511